Install Java 17 JDK in acceptance tests #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekohl
approved these changes
Jan 6, 2025
evgeni
changed the title
|
Marking as draft so we first finish #1116. |
|
Damn, I hate those tests. |
evgeni
force-pushed
the
java17
branch
2 times, most recently
from
4c47159 to
7d4e27b
Compare
Jenkins 2.479.1 requires Java 17 or newer and breaks with Java 11
Jenkins 2.479.1 requires Java 17 or newer and breaks with Java 11
bastelfreak
approved these changes
Jan 6, 2025
Me too. I really wish we have plugin management that understood dependencies. Ideally based on https://github.com/jenkinsci/plugin-installation-manager-tool. |
evgeni
commented
Jan 6, 2025
Comment on lines
+3
to
+4
| StartLimitIntervalSec: '0' | ||
| StartLimitBurst: '0' |
There was a problem hiding this comment.
Someone was so smart to set
StartLimitBurst=5
StartLimitIntervalSec=5m
as the default in the jenkins.service file -- we restart it a tad more often during tests, and well, at some point systemd refuses to restart further.
There was a problem hiding this comment.
Wouldn't hurt to have that in the commit message or comment, but here in the PR is a good start
bastelfreak
approved these changes
Jan 6, 2025
ekohl
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Jenkins 2.479.1 requires Java 17 or newer and breaks with Java 11
This Pull Request (PR) fixes the following issues